Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pv/one index per collection #97

Merged
merged 4 commits into from
Apr 27, 2022
Merged

Pv/one index per collection #97

merged 4 commits into from
Apr 27, 2022

Conversation

philvarner
Copy link
Collaborator

Related Issue(s):

Description:

  • Each collection is now in its own index
  • Search queries that are over specific collections also restrict the query to those indexes

PR Checklist:

  • Code is formatted and linted (run pre-commit run --all-files)
  • Tests pass (run make test)
  • Documentation has been updated to reflect changes, if applicable, and docs build successfully (run make docs)
  • Changes are added to the changelog

gadomski
gadomski requested changes Apr 26, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/core.py Show resolved Hide resolved
jonhealy1
jonhealy1 reviewed Apr 27, 2022
View reviewed changes
stac_fastapi/elasticsearch/stac_fastapi/elasticsearch/database_logic.py
COLLECTIONS_INDEX = "collections"
ITEMS_INDEX_PREFIX = "items_"

DEFAULT_INDICES = f"*,-*kibana*,-{COLLECTIONS_INDEX}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this reads like swearing haha - f*&%$* you *&^&kibana

jonhealy1
jonhealy1 approved these changes Apr 27, 2022
View reviewed changes
Copy link
Collaborator

@jonhealy1 jonhealy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving after Pete's comments are addressed.

philvarner
philvarner commented Apr 27, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@philvarner philvarner requested a review from gadomski April 27, 2022 14:34
@philvarner philvarner merged commit 3be5e1d into main Apr 27, 2022
@philvarner philvarner deleted the pv/one-index-per-collection branch April 27, 2022 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonhealy1 jonhealy1 jonhealy1 approved these changes

@gadomski gadomski gadomski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philvarner @gadomski @jonhealy1